This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
fixes issue where onboarding screen would not appear #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -309,8 +309,8 @@ app.on('ready', function() { | |||
| .then(function getAccounts() { | |||
| return ethereumNode.send('eth_accounts', []); | |||
| }) | |||
| .then(function onboarding(result) { | |||
| if (ethereumNode.isGeth && result && result.length === 0) { | |||
| .then(function onboarding(resultData) { | |||
There was a problem hiding this comment.
@hiddentao why you named that function?
There was a problem hiding this comment.
If it throws an error then in the stack trace it will show up, rather than "anonymous function", etc. Plus it makes the code easer to read.
|
Looks good! Thanks alex |
|
Thnx Alex. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.