add password visibilty toggle to onboarding #893
Conversation
|
|
||
| @method showPassword | ||
| */ | ||
| 'showPassword': function() { |
There was a problem hiding this comment.
would be better to call this passwordInputType or something similar.
There was a problem hiding this comment.
I copied this helper function from popupWindows_onboardingScreen_importAccount helpers.
Would you change that one too or do I miss your argument?
There was a problem hiding this comment.
i would also suggest changing that function helper name to passwordInputType
| <input type="{{passwordInputType}}" placeholder="{{i18n 'mist.popupWindows.requestAccount.enterPassword'}}" class="password {{#if TemplateVar.get 'passwordsMismatch'}}dapp-error{{/if}}"> | ||
| <input type="{{passwordInputType}}" placeholder="{{i18n 'mist.popupWindows.requestAccount.repeatPassword'}}" class="password-repeat {{#if TemplateVar.get 'passwordsMismatch'}}dapp-error{{/if}}"> | ||
| <br><br> | ||
| <input type="checkbox" id="show-password" name="elements_input_bool" class="abi-input"> |
There was a problem hiding this comment.
I'm strongly against using ids, as with the template scope and classes we can simply avoid using those.
Please change it to a class :)
|
Superseded by this: #909 |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
closes: #554