This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Fix: avoid deleting project folder #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
bugFixFolderDelete
branch
from
322b961 to
b7f3dd9
Compare
| @@ -103,18 +103,20 @@ QString FileIo::pathFromUrl(QString const& _url) | |||
| return path; | |||
| } | |||
|
|
|||
| void FileIo::makeDir(QString const& _url) | |||
| bool FileIo::makeDir(QString const& _url) | |||
There was a problem hiding this comment.
If you change the semantics of this function, you should also change how it is used.
In most places where this is used, the assumption is that the directory can be used afterwards and is clear.
yann300
force-pushed
the
bugFixFolderDelete
branch
from
40a368c to
12c0d6b
Compare
| @@ -279,8 +279,12 @@ function copyFiles(path, target) | |||
| continue | |||
| var deployDir = target + dirs[i].fileName + "/" | |||
| if (!fileIo.dirExists(deployDir)) | |||
There was a problem hiding this comment.
This process now fails silently if the directory already exists.
yann300
force-pushed
the
bugFixFolderDelete
branch
from
abf61e7 to
d39a237
Compare
| @@ -340,7 +349,11 @@ function generateFileName(name, extension) { | |||
| function regenerateCompilationResult() | |||
| { | |||
| fileIo.deleteDir(compilationFolder) | |||
There was a problem hiding this comment.
I think so. This function is called when mix is autogenerating the compilation result. this will never delete content added by the user.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#311