Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to CREATE2 #1346

Closed
pipermerriam opened this issue Oct 2, 2018 · 2 comments
Closed

changes to CREATE2 #1346

pipermerriam opened this issue Oct 2, 2018 · 2 comments
Labels
comp: eth effort: E1 hours prio: P2 required type: bug
Milestone
Constantinople

Comments

@pipermerriam
Copy link
Member

What is wrong?

CREATE2 is changing:

How can it be fixed

Wait to see where things land with the spec and update our implementation.
@pipermerriam pipermerriam added this to the Constantinople milestone Oct 2, 2018
@Bhargavasomu
Copy link
Contributor

Bhargavasomu commented Oct 3, 2018 •
edited
Loading

I would like to work on this issue. Could you please guide me regarding the codebase as to where to start?
Also I don't think I understood the issue 100%. Could you also elaborate on the issue we are trying to solve here?

@pipermerriam
Copy link
Member Author

Correct me if I'm wrong but this issue is going to require some depth of knowledge with this library which I don't believe you have. Probably best to stick to things labeled as "Good first issue" until you are more familiar with the codebase.

@pipermerriam pipermerriam mentioned this issue Oct 3, 2018
Closed
cburgdorf added a commit to cburgdorf/py-evm that referenced this issue Oct 15, 2018
@cburgdorf
Update CREATE2 gas cost calculation
1977abf 
Fixes ethereum#1346
@cburgdorf cburgdorf mentioned this issue Oct 15, 2018
Merged
cburgdorf added a commit to cburgdorf/py-evm that referenced this issue Oct 15, 2018
@cburgdorf
Update CREATE2 gas cost calculation
8fcac39 
Fixes ethereum#1346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: eth effort: E1 hours prio: P2 required type: bug
Projects
None yet
Milestone
Constantinople
Development

No branches or pull requests
3 participants
@cburgdorf @pipermerriam @Bhargavasomu