p2p/discovery: Workaround a parity bug that causes pongs with wrong token #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
approved these changes
Jul 13, 2018
p2p/kademlia.py
Outdated
| parity_token = k | ||
| break | ||
| if parity_token is not None: | ||
| del self.parity_pong_tokens[parity_token] |
There was a problem hiding this comment.
Another option if you like it better:
token_pairs = cytoolz.valfilter(lambda val: val == token, self.parity_pong_tokens)
for parity_token, _token in token_pairs:
del self.parity_pong_tokens[parity_token]
There was a problem hiding this comment.
How about just:
for k, v in tuple(self.parity_pong_tokens.items()):
if v == token:
del self.parity_pong_tokens[k]
break
There was a problem hiding this comment.
or a one-liner
self.parity_pong_tokens = cytoolz.valfilter(lambda val: val != token, self.parity_pong_tokens)
pipermerriam
approved these changes
Jul 13, 2018
…oken Parity 1.10 (and earlier) nodes send the wrong token on pong messages (openethereum/parity-ethereum#8038). This change keeps a mapping of wrong tokens to the ones we expect, and uses that whenever we get a pong with one of those wrong tokens.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parity 1.10 (and earlier) nodes send the wrong token on pong messages
(openethereum/parity-ethereum#8038). This change keeps
a mapping of wrong tokens to the ones we expect, and uses that whenever
we get a pong with one of those wrong tokens.