Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: Add a test for the limit on block number sequence generator #1051

Merged
merged 1 commit into from
Jul 21, 2018
Merged

p2p: Add a test for the limit on block number sequence generator #1051

merged 1 commit into from
Jul 21, 2018

Conversation

gsalgado
Copy link
Contributor

No description provided.

@gsalgado gsalgado mentioned this pull request Jul 20, 2018
Merged
@gsalgado gsalgado requested a review from carver July 20, 2018 10:47
carver
carver approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, sure, it seemed a little pedantic to have a method that's whole job is to import and enforce the constant. And maybe it will be brittle to internal refactors... but I don't have a better idea right now.

@gsalgado gsalgado merged commit 4b3e30b into ethereum:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carver carver carver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsalgado @carver