Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create guide on how to create plugins #1429

Merged
merged 3 commits into from
Oct 29, 2018

Commits on Oct 28, 2018

  1. Make accidentially private methods public

    These methods were named so that they appeared
    private by convention. This convention causes
    trouble in the documentation where these methods
    are righfully dropped. Since these methods aren't
    really private in reality (they need to be overwritten
    in subclasses), they were renamed, migrating their
    naming from `_*` to `do_*`.
    cburgdorf committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    28bfd62 View commit details
    Browse the repository at this point in the history
  2. Plugins: replace running bool with PluginStatus enum

    This enables the plugin to read the status of the
    four formal states a plugin can be in. Previously
    even though the four states existed implicitly,
    it could only be differentiated between the
    STARTED/STOPPED state based on the `running`
    bool.
    
    This change also has the nice benefit that we
    can make stronger assumptions about the status
    inside `start()` and raise an exception if
    `start()` was called on a plugin that isn't in
    the correct status to call `start()`
    cburgdorf committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    55e5f63 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. Add rudimentary plugin guide

    Relates to ethereum#1103
    cburgdorf committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    f4184a5 View commit details
    Browse the repository at this point in the history