Add get_transaction_receipt method to Chain API #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhargavasomu
force-pushed
the
chain_methods
branch
from
2dc9ded to
75b2872
Compare
|
@cburgdorf could you please review this? This is a part of the PR ethereum/trinity#122 |
cburgdorf
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
This looks good to me but I wouldn't mind @pipermerriam giving it a second look just because it's adding a method to one of the core abstractions of the EVM (which I do agree is needed).
eth/db/chain.py
Outdated
| @@ -143,6 +143,12 @@ def get_transaction_by_index( | |||
| def get_transaction_index(self, transaction_hash: Hash32) -> Tuple[BlockNumber, int]: | |||
| raise NotImplementedError("ChainDB classes must implement this method") | |||
|
|
|||
| @abstractmethod | |||
There was a problem hiding this comment.
nitpick: would be nice to have this directly next to get_receipts.
Bhargavasomu
force-pushed
the
chain_methods
branch
from
75b2872 to
7f79cbf
Compare
|
@pipermerriam review please. Thankyou. |
|
@Bhargavasomu went ahead and merged it in preparation of a new release being cut within the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently, if we want to implement the
getTransactionReceiptJSON RPC functionality, then we would have to go all the way to theChainDBpart of theChain API. This PR aims to make this functionality available as part of theChain API, so that the convention of JSON RPC implementations using only the Chain API and not thechaindbpart of theChain, is followed.How was it fixed?
The
get_receipt_by_indexofchaindbwas used in theChain API, so as to abstract the usage.Cute Animal Picture