Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented May 21, 2018

Fixes #737

What was wrong?

Looks like we semi-regularly encounter situations where we're trying to bond with the same peer which causes an AlreadyWaiting exception to bubble.

How was it fixed?

  • Catch the AlreadyWaiting exception in bond and return False indicating that bonding failed
  • Do a check prior to pinging to check if we're already waiting for a pong.
  • Use context manager for managing self.ping_callbacks to ensure the event is always cleared.

Cute Animal Picture

20140105_453603 xml-chicks with hats 4

@pipermerriam pipermerriam force-pushed the piper/handle-already-waiting-error-during-bonding branch from fa6af82 to ede496d Compare May 21, 2018 03:17
@pipermerriam pipermerriam requested a review from gsalgado May 21, 2018 03:17
@pipermerriam pipermerriam force-pushed the piper/handle-already-waiting-error-during-bonding branch from ede496d to c0a6b7a Compare May 21, 2018 03:19
@pipermerriam
Copy link
Member Author

This doesn't actually appear to have solved the problem but I need to investigate more in the morning when I'm fresh.

@pipermerriam
Copy link
Member Author

replaced by #765

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trinity raises AlreadyWaiting error semi-regularly

1 participant