This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Piper/handle already waiting error during bonding #738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737
What was wrong?
Looks like we semi-regularly encounter situations where we're trying to bond with the same peer which causes an
AlreadyWaiting
exception to bubble.How was it fixed?
AlreadyWaiting
exception inbond
and returnFalse
indicating that bonding failedself.ping_callbacks
to ensure the event is always cleared.Cute Animal Picture