trinity: Proper cleanup in RopstenLightNode #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsalgado
force-pushed
the
trinity-shutdown-issues
branch
from
0d5a12c to
3f6d058
Compare
RopstenLightNode wasn't passing its CancelToken down to its sub-services, so its _cleanup() method could return while we still had pending asyncio tasks Closes: ethereum#918
gsalgado
force-pushed
the
trinity-shutdown-issues
branch
from
3f6d058 to
2a1946d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RopstenLightNode wasn't passing its CancelToken down to its
sub-services, so its _cleanup() method could return while we still had
pending asyncio tasks
Closes: #918