Skip to content
This repository has been archived by the owner on Aug 8, 2018. It is now read-only.

Use the new eth-keyfile module, fixes #292 #293

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AndreMiras
Copy link

Use the new eth-keyfile module to encrypt/decrypt keyfile.
This makes it way faster to create and unlock accounts.
For instance with 100K PBKDF2 iteration rather than 100.
Running pyethapp/tests/test_accounts.py was outputing:

9 passed in 112.07 seconds

After the pull request it's now:

9 passed in 2.41 seconds

Use the new eth-keyfile module to encrypt/decrypt keyfile.
This makes it way faster to create and unlock accounts.
For instance with 100K PBKDF2 iteration rather than 100.
Running `pyethapp/tests/test_accounts.py` was outputing:
```
9 passed in 112.07 seconds
```
After the pull request it's now:
```
9 passed in 2.41 seconds
```
@alexandermuehle
Copy link

pyethapp is not upgraded to python3 so it is not compatible with eth-keys

@AndreMiras
Copy link
Author

Hi @alexandermuehle thank you for your feedback!
The good news is that I'm using pyethapp for my Python3 project and it's working OK see here https://github.com/AndreMiras/EtherollApp
Do you want me to double check if all test are passing and come with a pull request that update tox and Jenkins for Python3?

@alexandermuehle
Copy link

alexandermuehle commented Apr 10, 2018

If I remember correctly json-rpc functions didn't work under python3 when I last tried it under py3, but I agree since the rest of the eth projects seem to be moving towards python3, this project should follow.
#272 didn't receive an official response though would be nice if a maintainer could chime in

@alexandermuehle
Copy link

@vbuterin @ChihChengLiang @pipermerriam @hwwhww @changwu-tw
any of you still active or has this project been abandoned?

@pipermerriam
Copy link
Member

To the best of my knowledge this project is largely unmaintained. If you're looking for a python ethereum node, check out trinity which is currently being developed within the py-evm codebase

@alexandermuehle
Copy link

thanks for clearing it up @pipermerriam, maybe add a "deprecated" note on the pyethapp readme so people find the right python implementation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants