Update plugin API #1196
Merged
Update plugin API #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
updatepmluginAPI
branch
from
585b7a1
to
ad6d51b
Compare
yann300
force-pushed
the
updatepmluginAPI
branch
from
ad6d51b
to
2cfd1ee
Compare
Fi3
reviewed
Apr 13, 2018
src/app/plugin/pluginManager.js
Outdated
| data.arguments.push((error, result) => { | ||
| response(data.type, data.id, error, result) | ||
| data.value.push((error, result) => { | ||
| response(data.key, data.type, data.id, error, result) | ||
| }) | ||
| api[data.key][data.type].apply({}, data.arguments) |
Fi3
reviewed
Apr 13, 2018
test-browser/plugin/remix.js
Outdated
| @@ -8,25 +8,31 @@ window.addEventListener('message', receiveMessage, false) | |||
| window.onload = function () { | |||
| document.querySelector('input#testmessageadd').addEventListener('click', function () { | |||
| window.parent.postMessage(JSON.stringify({ | |||
| action: 'request', | |||
| key: 'editor', | |||
Fi3
reviewed
Apr 13, 2018
test-browser/plugin/remix.js
Outdated
| }) | ||
|
|
||
| document.querySelector('input#testmessageremove').addEventListener('click', function () { | ||
| window.parent.postMessage(JSON.stringify({ | ||
| action: 'request', | ||
| key: 'editor', |
Fi3
reviewed
Apr 13, 2018
test-browser/plugin/remix.js
Outdated
| }) | ||
|
|
||
| document.querySelector('input#testmessagerget').addEventListener('click', function () { | ||
| window.parent.postMessage(JSON.stringify({ | ||
| action: 'request', | ||
| key: 'editor', |
serapath
reviewed
Apr 16, 2018
| * type: <string>, | ||
| * value: <array>, | ||
| * error: (see below) | ||
| *} |
There was a problem hiding this comment.
I just checked again: https://github.com/ethereum/remix-ide/issues/1156
- The original proposal is
var { id, status, type, key, value } = msg - You said you would like to add the
actionfield to indicate "response/notification/request". - That would make it
var { action, id, status, type, key, value } = msg - But now the
statusis/was renamed toerrori guess.
Just to make sure how i have to think about it :-)
So i guess we now have: var { action, id, error: status, type, key, value } = msg
I would say that is fine.
There was a problem hiding this comment.
The above comment is just for me to clarify.
If this is how it's meant, i would say the PR looks good to me :-)
There was a problem hiding this comment.
yes except that error is undefined if there's no error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following https://github.com/ethereum/remix-ide/issues/1156