Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile-tab: add evmVersion #1998

Merged
merged 4 commits into from
Jun 17, 2019
Merged

compile-tab: add evmVersion #1998

merged 4 commits into from
Jun 17, 2019

Conversation

scottt
Copy link
Contributor

@scottt scottt commented May 20, 2019

Specifying a specific EVM version for solc to target
is useful when targetting older private chains deployments
with the latest compiler.

This work in progress patch adds an "EVM Version" drop down menu
in the compiler tab.

This patch depends on ethereum/remix#1193
in remix-solidity to pass down the evmVersion option.

@scottt scottt force-pushed the scottt-compiler-tab-add-evmVersion-select branch from 8aa03d7 to d8ff2dd Compare May 27, 2019 04:59
@scottt scottt changed the title [WIP] compile-tab: add evmVersion compile-tab: add evmVersion May 29, 2019
@scottt
Copy link
Contributor Author

scottt commented May 29, 2019

To my knowledge, the only things this patch is missing is for a version of remix-solidity with ethereum/remix#1193 merged to be released and to depend on that version and maybe an automated browser test.

Regarding the CircleCI browser test failure (ERROR: Unable to locate element: "#icon-panel div[plugin="pluginManager"]"), my current theory is that it's not caused by this patch, because no relevant code was touched, but would like to confirm with you guys.

@yann300 yann300 force-pushed the scottt-compiler-tab-add-evmVersion-select branch from d8ff2dd to 6312a0a Compare June 13, 2019 14:33
@yann300
Copy link
Collaborator

yann300 commented Jun 13, 2019

@scottt just rebasing

scottt and others added 4 commits June 17, 2019 12:54
@scottt @yann300
[WIP] compile-tab: add evmVersion
3997762 
Specifying a specific EVM version for `solc` to target
is useful when targetting older private chains deployments
with the latest compiler.

This work in progress patch adds an "EVM Version" drop down menu
in the compiler tab.

This patch depends on ethereum/remix#1193
in `remix-solidity` to pass down the `evmVersion` option.
@lucien-tt @yann300
adjust compiler selector layout
09e6b7c
@scottt @yann300
compilerContainer: don't use options[0] to current EVM target
2f121fe
@yann300
bump version
e03a46b
@yann300 yann300 force-pushed the scottt-compiler-tab-add-evmVersion-select branch from 6312a0a to e03a46b Compare June 17, 2019 10:56
@yann300 yann300 merged commit dd92765 into ethereum:master Jun 17, 2019
@yann300
Copy link
Collaborator

yann300 commented Jun 17, 2019

Thanks for this PR ;)

@scottt
Copy link
Contributor Author

scottt commented Jun 17, 2019

@yann300 thanks for reviewing and merging the patch!

Does the "Release (automation) moved this from approved (for the Tuesday release) to Done" message mean that I can expect to see this change live on http://remix-alpha.ethereum.org on June 18?

@scottt scottt deleted the scottt-compiler-tab-add-evmVersion-select branch June 17, 2019 11:45
@yann300
Copy link
Collaborator

yann300 commented Jun 17, 2019 •
edited
Loading

that should show up in remix-alpha anytime soon (like today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann300 yann300 yann300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottt @yann300 @lucien-tt