use Web3 utils instead of execution context web3 #2475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurimatias
changed the title
LianaHus
reviewed
Dec 12, 2019
| @@ -7,6 +7,7 @@ var typeConversion = remixLib.execution.typeConversion | |||
| var txExecution = remixLib.execution.txExecution | |||
| var CompilerAbstract = require('../../../compiler/compiler-abstract') | |||
| var EventManager = remixLib.EventManager | |||
| var Web3 = require('web3') | |||
There was a problem hiding this comment.
could you please always use const if possible?
iurimatias
force-pushed
the
web3_utils
branch
from
8b11812
to
e448ded
Compare
GrandSchtroumpf
approved these changes
Dec 30, 2019
| @@ -7,6 +7,7 @@ var typeConversion = remixLib.execution.typeConversion | |||
| var txExecution = remixLib.execution.txExecution | |||
| var CompilerAbstract = require('../../../compiler/compiler-abstract') | |||
| var EventManager = remixLib.EventManager | |||
| var Web3 = require('web3') | |||
There was a problem hiding this comment.
It's usually better for tree shaking to be more precise about the import: const { utils } from 'web3' or with require const { utils } = require('web3')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of moving to remix as web3 provider