Updates quorum urls #2485
Merged
Updates quorum urls #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the Quorum plugin iframe being loaded from an https site all the time, even if they were using http remix, users were not able to connect to a non-localhost http node.
So we moved the Quorum plugin from being hosted on github pages to a subdomain of our official site. This allows us to serve the page as both http and https.
We also changed the url to be protocol relative ("//url" rather than "https://url"), so that when the iframe element is loaded, it will use the scheme of the top-level page. So if you load http remix, you'll get the http quorum plugin. This should make the plugin accessible to more users, especially those running development environments that are not ssl protected.