Refactor dropdown logic #2506
Merged
Refactor dropdown logic #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurimatias
force-pushed
the
refactor_logic1
branch
from
09e5544
to
3988121
Compare
GrandSchtroumpf
approved these changes
Dec 30, 2019
|
|
||
| const compilerContracts = this.dropdownLogic.getCompilerContracts() | ||
| const confirmationCb = this.getConfirmationCb(modalDialog, confirmDialog) | ||
|
|
There was a problem hiding this comment.
As you have only one source of error possible I would recommend :
try {
const contractMetadata = await this.runView.call('compilerMetadata', 'deployMetadataOf', selectedContract.name)
const compilerContracts = this.dropdownLogic.getCompilerContracts()
const confirmationCb = this.getConfirmationCb(modalDialog, confirmDialog)
} catch (error) {
return statusCb(`creation of ${selectedContract.name} errored: ` + error)
}| if (!content.gasPriceStatus) { | ||
| cancelCb('Given gas price is not correct') | ||
| } else { | ||
| var gasPrice = this.dropdownLogic.toWei(content.querySelector('#gasprice').value, 'gwei') |
There was a problem hiding this comment.
use const when adding new piece of code.
There was a problem hiding this comment.
I'll do the whole syntax update stuff on the remix-side of things in a different PR (just like for remix)
| determineGasFees (tx) { | ||
| const determineGasFeesCb = (gasPrice, cb) => { | ||
| let txFeeText, priceStatus | ||
| // TODO: this try catch feels like an anti pattern, can/should be |
There was a problem hiding this comment.
Can you create an issue for that and reference it here: TODO(#1234) ... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(finally) extracts the modal/confirm dialogs from the dropdown logic, moves logic related to execution context and udapp into a blockchain module