Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor executionContext and udapp, into common class #2510

Merged
merged 19 commits into from
Jan 22, 2020
Merged

Refactor executionContext and udapp, into common class #2510

merged 19 commits into from
Jan 22, 2020

Conversation

iurimatias
Copy link
Member

No description provided.

@iurimatias iurimatias changed the title Refactor logic2 Refactor executionContext and udapp, into common class Dec 30, 2019
@yann300
Copy link
Collaborator

yann300 commented Jan 7, 2020

we should wait the release before merging this though
cc @LianaHus

@iurimatias
refactor recorder logic to extract modal and confirm dialogs out, use…
035ea3f 
… blockchain class
@iurimatias
move common fromWei/toWei/determineGasFee methods into blockchain module
a3946e6
@iurimatias
refactor out of the recorder executioncontext and udapp
0d5765b
@iurimatias
fix linting issues
b2d914c
@iurimatias
add missing config param
c4d47eb
@iurimatias
add missing params to udapp events
e2074ac
@iurimatias
move blockchain specific logic from settings to blockchain model
5c8c825
@iurimatias
remove old settings file
a32ed43
@iurimatias
move compiler-data into blockchain module; load blockchain module fro…
e7bc017 
…m run-tab
@iurimatias
use blockchain module instead of executio ncontext for cmd interpreter
e65f355
@iurimatias
use blockchain object in txlogger
389b6ec
@iurimatias
remove executionContext from mainview
a12d40f
@iurimatias
use blockchain object instead of executionContext in transactionRecei…
30fe405 
…ptResolver
@iurimatias
abstract txlistener
222e698
@iurimatias
fix linting issues
4efd180
@iurimatias
move txDetailsLink into remix-ide
68d540c
@iurimatias
remove executioncontext param from makeUdapp
4de0d42
@iurimatias
remove udapp param from make-udapp
6737ba7
@iurimatias
remove unnecesary udapp params
5dc2ff2
@iurimatias iurimatias merged commit 1ff9e8c into master Jan 22, 2020
@iurimatias iurimatias deleted the refactor_logic2 branch January 22, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann300 yann300 yann300 approved these changes

@GrandSchtroumpf GrandSchtroumpf Awaiting requested review from GrandSchtroumpf

@LianaHus LianaHus Awaiting requested review from LianaHus

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iurimatias @yann300