Load plugins from parameters #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
loadPluginsFromParameters
branch
2 times, most recently
from
e21c899
to
034f028
Compare
yann300
force-pushed
the
loadPluginsFromParameters
branch
from
034f028
to
0a876d5
Compare
GrandSchtroumpf
approved these changes
Jan 6, 2020
src/remixAppManager.js
Outdated
| localStorage.setItem('workspace', JSON.stringify(actives)) | ||
| } | ||
| }, | ||
| get: () => { |
There was a problem hiding this comment.
use inline arrow function: get: () => JSON.parse(localStorage.getItem('workspace'))
src/remixAppManager.js
Outdated
| this.loaders['queryParams'] = { | ||
| set: () => {}, | ||
| get: () => { | ||
| let plugins = queryParams.get()['plugins'] |
There was a problem hiding this comment.
you can use const & destructuration here: const { plugins } = queryParams.get()
src/remixAppManager.js
Outdated
| } | ||
|
|
||
| set (plugin, actives) { | ||
| this.loaders[this.current].set(plugin, actives) |
There was a problem hiding this comment.
Might be worthy to have a getter method in the class for that :
get currentLoader() {
return this.loaders[this.current]
}
test-browser/tests/workspace.js
Outdated
| @@ -0,0 +1,17 @@ | |||
| 'use strict' | |||
| var init = require('../helpers/init') | |||
There was a problem hiding this comment.
Let's use const for new code
| @@ -232,3 +231,40 @@ export class RemixAppManager extends PluginEngine { | |||
| ] | |||
| } | |||
| } | |||
|
|
|||
| class PluginLoader { | |||
There was a problem hiding this comment.
Add comment to explain what this class is about.
yann300
force-pushed
the
loadPluginsFromParameters
branch
from
6cd8a2d
to
a242047
Compare
LianaHus
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: