Listening to Lexon compilation finished. #2557

step21 · 2020-01-27T21:19:49Z

No description provided.

yann300 · 2020-01-28T13:17:14Z

could you try first registering and activating your plugin first, and then activating the run module please?
If this is fixing it, the only way for the moment, would be to add the plugin to the list https://github.com/ethereum/remix-plugins-directory/tree/master/plugins (please create a PR) and please mark it as alpha (using semver) - you'll have to host it on https
then we'll make the necessary to make it available in remix

src/app/compiler/compiler-artefacts.js

src/app/tabs/runTab/contractDropdown.js

src/app/ui/landing-page/landing-page.js

src/remixAppManager.js

step21 · 2020-02-19T12:45:45Z

It should be properly rebased/merged now. Is it fine like this or do you want me to do a new PR/squash commits? I couldn't properly test because without plugin list, without the part in natives it will not work locally. :)

src/remixAppManager.js

yann300 · 2020-02-19T14:27:37Z

src/app/tabs/runTab/model/dropdownlogic.js

@@ -31,6 +31,10 @@ class DropdownLogic {
    this.runView.on('vyper', 'compilationFinished', (file, source, languageVersion, data) =>
      broadcastCompilationResult(file, source, languageVersion, data)
    )
+    this.runView.on('lexon', 'compilationFinished', (file, source, languageVersion, data) =>
+      broadcastCompilationResult(file, source, languageVersion, data)
+      // console.log('broadcasting compilation result ', file, source, languageVersion, data)


could you remove the comment?

yann300 · 2020-02-19T14:28:20Z

I think that should be ok, could you address the 2 other commits and squash all the commits, then we can merge it

author step21 <step21@devtal.de> 1580159823 +0100 committer step21 <step21@devtal.de> 1582131959 +0100 Lexon modifications

step21 · 2020-02-19T17:21:17Z

So I should have addressed the comments and squashed them. Hopefully nothing broke :)

yann300 · 2020-03-04T12:19:40Z

e2e tests checked by #2621