Script Execution - Async/Await support #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
vmSandbox
branch
12 times, most recently
from
a542e30
to
d8f9937
Compare
ioedeveloper
approved these changes
Feb 10, 2020
yann300
force-pushed
the
vmSandbox
branch
5 times, most recently
from
af9ae5d
to
5329c10
Compare
yann300
force-pushed
the
vmSandbox
branch
4 times, most recently
from
652199f
to
7fc5ec0
Compare
yann300
force-pushed
the
vmSandbox
branch
2 times, most recently
from
ca7bf6e
to
b3dd967
Compare
LianaHus
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by running the script inside a dedicated plugin instead of using the npm module
vm-browserify.For the moment we loose support for Web3 Provider. This will be added in the next PR.
Important note, the plugin runs in the same domain as the app, we need to evaluate whether we really want that. Having a separate domain is ofc possible but require more devops and maintenance.