Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal e2e tests #2593

Merged
merged 25 commits into from
Feb 21, 2020
Merged

Terminal e2e tests #2593

merged 25 commits into from
Feb 21, 2020

Conversation

ioedeveloper
Copy link
Member

No description provided.

@yann300
Copy link
Collaborator

yann300 commented Feb 12, 2020

this contains change in test-browser/tests/gist.js . should that stay in this PR?

@ioedeveloper
Copy link
Member Author

I moved importFromGist.js tests into gist.js tests since they are all gist tests. I just thought i could include it in this PR since it a minor change but I can take it out of this PR and open a new PR for it if you are more comfortable with that.

@ioedeveloper
Copy link
Member Author

Moreover, i still plan on updating this test with data-attributes once #2591 is merged.

@yann300
Copy link
Collaborator

yann300 commented Feb 17, 2020

can that be merged?

@ioedeveloper
Copy link
Member Author

ioedeveloper commented Feb 17, 2020 •
edited
Loading

Yes, it is ready to be merged, but it does not contain your recent fix in #2605 . So it is probably best that #2605 be merged first and i update this PR with the changes.

@yann300 yann300 merged commit c94af82 into master Feb 21, 2020
@yann300 yann300 deleted the terminal-e2e-tests branch February 21, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann300 yann300 yann300 approved these changes

Assignees
No one assigned
Labels
browser tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ioedeveloper @yann300