Default to dark theme #2600
Merged
Default to dark theme #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LianaHus
reviewed
Feb 14, 2020
| @@ -39,7 +39,7 @@ export class ThemeModule extends Plugin { | |||
| config: registry.get('config').api | |||
| } | |||
| this.themes = themes.reduce((acc, theme) => ({ ...acc, [theme.name]: theme }), {}) | |||
| this.active = this._deps.config.get('settings/theme') ? this._deps.config.get('settings/theme') : 'Flatly' | |||
| this.active = this._deps.config.get('settings/theme') ? this._deps.config.get('settings/theme') : 'Dark' | |||
There was a problem hiding this comment.
there are some issues still with the theme. Would be nice to merge this after update
There was a problem hiding this comment.
Is this ok to merge now since an update has been pushed recently?
cc @ryestew
There was a problem hiding this comment.
I think this is fine to merge now. We should probably put a link on the landing page to docs about changing themes. Mostly because we are going to a default dark theme and that might surprise some people.
ryestew
approved these changes
Feb 24, 2020
| @@ -39,7 +39,7 @@ export class ThemeModule extends Plugin { | |||
| config: registry.get('config').api | |||
| } | |||
| this.themes = themes.reduce((acc, theme) => ({ ...acc, [theme.name]: theme }), {}) | |||
| this.active = this._deps.config.get('settings/theme') ? this._deps.config.get('settings/theme') : 'Flatly' | |||
| this.active = this._deps.config.get('settings/theme') ? this._deps.config.get('settings/theme') : 'Dark' | |||
There was a problem hiding this comment.
I think this is fine to merge now. We should probably put a link on the landing page to docs about changing themes. Mostly because we are going to a default dark theme and that might surprise some people.
LianaHus
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.