remove the old permissionss saved in localstorage #2670
Conversation
src/app/ui/persmission-handler.js
Outdated
| @@ -41,6 +41,11 @@ export class PermissionHandler { | |||
|
|
|||
| constructor () { | |||
| this.permissions = this._getFromLocal() | |||
| // remove the old permissions saved in versions < 0.9.4 since the structior has been changed | |||
| if (!localStorage.getItem(['isNewEngine'])) { | |||
There was a problem hiding this comment.
why is this an array? ['isNewEngine']
There was a problem hiding this comment.
ah, a typo. will fix it
src/app/ui/persmission-handler.js
Outdated
| @@ -41,6 +41,11 @@ export class PermissionHandler { | |||
|
|
|||
| constructor () { | |||
| this.permissions = this._getFromLocal() | |||
| // remove the old permissions saved in versions < 0.9.4 since the structior has been changed | |||
| if (!localStorage.getItem('isNewEngine')) { | |||
There was a problem hiding this comment.
perhaps having a more precise flag like isNewEngine-<version_number> would be better, the structure might change again in the future
There was a problem hiding this comment.
well i had that before but then remove it. I can add it if you want, i didn't want to overthink
| this.currentVersion = 1 | ||
| // here we remove the old permissions saved before adding 'permissionVersion' | ||
| // since with v1 the structior has been changed because of new engine ^0.2.0-alpha.6 changes | ||
| if (!localStorage.getItem('permissionVersion')) { |
There was a problem hiding this comment.
that still won't work like this, you have to do
if (localStorage.getItem('permissionVersion') !== this.currentVersion) {
There was a problem hiding this comment.
if this.currentVersion is 2. or 4. the user loads and there is no 'permissionVersion' this would be undefined. ok i can leave the check for undefined.
now lets say permissionVersion is 1 and we have currentVersion=2 now so 1 != 2 we gonna rm the old one(correct) and set it to 1(incorrect).
with my logic, if the 'permissionVersion' was not introduced it will rm the old permissions and set 1 to permissionVersion.
if it is already there will not do anything
since the structure has been changed
fixing https://github.com/ethereum/remix-ide/issues/2663