Fetch and compile before debugging #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
fix#2742
branch
2 times, most recently
from
54c0ba9
to
dfd3840
Compare
yann300
force-pushed
the
fix#2742
branch
10 times, most recently
from
465781c
to
e5d4c23
Compare
yann300
force-pushed
the
fix#2742
branch
2 times, most recently
from
774de91
to
5e152a0
Compare
yann300
force-pushed
the
fix#2742
branch
2 times, most recently
from
ef3dfd9
to
078977d
Compare
yann300
force-pushed
the
fix#2742
branch
5 times, most recently
from
3fff6ae
to
4667990
Compare
|
For testing the code,
This will unfortunately require this PR from the remix repo ethereum/remix#1463 |
yann300
force-pushed
the
fix#2742
branch
2 times, most recently
from
d9a6777
to
fe79372
Compare
LianaHus
reviewed
Apr 27, 2020
src/app/tabs/debugger-tab.js
Outdated
| this.debuggerUI = new DebuggerUI(this.el.querySelector('#debugger'), this.blockchain) | ||
|
|
||
| this.on('fetchAndCompile', 'compiling', (settings) => { | ||
| toaster(yo`<div><b>Recompiling and debugging with params</b><pre>${JSON.stringify(settings, null, '\t')}</pre></div>`) |
There was a problem hiding this comment.
could you please add class="text-left" to this pre to align text to the left
LianaHus
reviewed
Apr 28, 2020
| name === 'main' ? 'mainnet' : name // source-verifier api expect "mainnet" and not "main" | ||
| let data | ||
| try { | ||
| data = await this.call('source-verification', 'fetch', contractAddress, name.toLowerCase()) |
There was a problem hiding this comment.
here is the format {id:network.id, name}
There was a problem hiding this comment.
@LianaHus you don't need to do toLowerCase it will be handled on the API level.
LianaHus
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs ethereum/remix#1464
fix #2742