Allow multiple highlight per plugin #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
fix#2793
branch
2 times, most recently
from
93d46dd
to
a061f4a
Compare
| @@ -0,0 +1,15 @@ | |||
| const EventEmitter = require('events') | |||
|
|
|||
| class ElementIsPresent extends EventEmitter { | |||
There was a problem hiding this comment.
Nightwatch api methods contains commands that check for element present and element not present (Nightwatch API), so there may be no need to implement custom commands for those assertions. Except you have other reasons for wanting to use a custom command.
ioedeveloper
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/ethereum/remix-ide/issues/2793