new Ace editor dark theme #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryestew
reviewed
Jun 2, 2020
There was a problem hiding this comment.
What will the effect of removing the theme from the CDN?
I think we wanted it in the CDN originally so that external plugins could have access to it.
Although the external plugins do not seem to have any issues with the theme's placement in the asset's folder - I think. Ahhh no Provable for instance still accesses the theme through cloudinary.
The remix icon on the top of the icon panel is still a svg.
|
Svg is also fine. |
ryestew
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/ethereum/remix-ide/issues/2039
fix https://github.com/ethereum/remix-ide/issues/2831