preactivate solidity #2879
Merged
preactivate solidity #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Jun 4, 2020
src/app.js
Outdated
| @@ -406,6 +406,10 @@ Please make a backup of your contracts and start using http://remix.ethereum.org | |||
| const framingService = new FramingService(sidePanel, menuicons, mainview, this._components.resizeFeature) | |||
| framingService.start() | |||
|
|
|||
| // preactivate solidity plugin | |||
There was a problem hiding this comment.
I think we should preactivate solidity and udapp, only if the workspace is empty, not always
There was a problem hiding this comment.
your are right. I'll do the change.
yann300
reviewed
Jun 4, 2020
| @@ -400,7 +400,13 @@ Please make a backup of your contracts and start using http://remix.ethereum.org | |||
| await appManager.activatePlugin(['home', 'sidePanel', 'hiddenPanel', 'pluginManager', 'fileExplorers', 'settings', 'contextualListener', 'scriptRunner', 'terminal', 'fetchAndCompile']) | |||
|
|
|||
| // Set workspace after initial activation | |||
| if (Array.isArray(workspace)) await appManager.activatePlugin(workspace) | |||
| if (Array.isArray(workspace)) { | |||
There was a problem hiding this comment.
you should check for the length here
yann300
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/ethereum/remix-ide/issues/2795