Remixd Websocket Plugin #2891
Merged
Remixd Websocket Plugin #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioedeveloper
force-pushed
the
remixd-websocket
branch
4 times, most recently
from
c409598
to
aa88954
Compare
ioedeveloper
force-pushed
the
remixd-websocket
branch
from
ed8a847
to
903f90b
Compare
yann300
reviewed
Jun 23, 2020
| if (provider) { | ||
| const { type } = provider | ||
|
|
||
| return self.updatePath(type) |
There was a problem hiding this comment.
is it not needed anymore? I think this was changed to : self.updatePath(self.files.type)
There was a problem hiding this comment.
Yes, it is no longer needed. I moved it to https://github.com/ethereum/remix-ide/pull/2891/files#diff-4b3872e86385f2fb931b0375fe866ef5R151
yann300
approved these changes
Jun 24, 2020
yann300
force-pushed
the
remixd-websocket
branch
2 times, most recently
from
4284392
to
fde4629
Compare
LianaHus
reviewed
Jun 30, 2020
| } | ||
| } | ||
| this._appManager.on('remixd', 'folderAdded', (path) => { | ||
| this.event.trigger('folderAdded', [this.addPrefix(path)]) |
There was a problem hiding this comment.
Don't you need folder removed?
There was a problem hiding this comment.
file and folder removed share the same event fileRemoved
LianaHus
approved these changes
Jun 30, 2020
This reverts commit dddd824.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/ethereum/remix-ide/issues/2811