adding custom path to Unit Testing #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Jun 15, 2020
src/app/tabs/test-tab.js
Outdated
| @@ -281,7 +281,7 @@ module.exports = class TestTab extends ViewPlugin { | |||
| const stopBtnLabel = document.getElementById('runTestsTabStopActionLabel') | |||
| stopBtnLabel.innerText = 'Stop' | |||
| if (this.data.selectedTests.length !== 0) { | |||
| const runBtn = document.getElementById('runTestsTabRunAction') | |||
| const runBtn = document.getElemenstById('runTestsTabRunAction') | |||
LianaHus
force-pushed
the
utworkshop
branch
2 times, most recently
from
d92986d
to
10798de
Compare
ryestew
requested changes
Jun 23, 2020
src/app/tabs/test-tab.js
Outdated
| @@ -495,7 +523,8 @@ module.exports = class TestTab extends ViewPlugin { | |||
| <div class="${css.testTabView} px-2" id="testView"> | |||
| <div class="${css.infoBox}"> | |||
| <p class="text-lg"> Test your smart contract in Solidity.</p> | |||
| <p> Click on "Generate" to generate a sample test file.</p> | |||
| <p> Click on "Generate" to generate a sample test file in.</p> | |||
There was a problem hiding this comment.
This sentence should end with a : not a .
Or maybe this will be more clear:
Click on "Generate" to generate a sample test file in this folder:
Or put a label and use this sentence:
Choose a folder & click "Generate" for a sample test file.
LianaHus
commented
Jun 30, 2020
src/app/tabs/test-tab.js
Outdated
| updateDirList (e) { | ||
| if (e.keyCode === 191) { | ||
| this.testTabLogic.dirList(this._view.el.getElementsByClassName('custom-select')[0].value).then((options) => { | ||
| options.forEach((path) => this.uiPathList.appendChild(yo`<option>${path}</option>`)) |
There was a problem hiding this comment.
need to clear the list first
yann300
reviewed
Jul 2, 2020
src/app/tabs/test-tab.js
Outdated
| updateDirList (e) { | ||
| if (e.keyCode === 191) { | ||
| for (var o of this.uiPathList.querySelectorAll('option')) o.remove() | ||
| this.testTabLogic.dirList(this._view.el.getElementsByClassName('custom-select')[0].value).then((options) => { |
There was a problem hiding this comment.
I think you should not fetch element from class name, doesn't look like robust..
ryestew
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.