Filemanager external api e2e #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryan7157860
approved these changes
Jun 24, 2020
bryan7157860
approved these changes
Jun 24, 2020
yann300
reviewed
Jun 29, 2020
|
|
||
| this.fileRenamedEvent(oldPath, newPath, !isFile) | ||
| if (isFile) { |
There was a problem hiding this comment.
looks like fileRenameEvent is not called and that the event located at https://github.com/ethereum/remix-ide/pull/2916/files#diff-f28e4232b4dbf7d53c7b5543bdc9ad4fR314 will never be trigerred
There was a problem hiding this comment.
fileRenamedEvent is triggered after rename from provider.
remix-ide/src/app/files/fileManager.js
Line 270 in 1b2bac5
So the changes are in order.
There was a problem hiding this comment.
Adding a call to the fileRenamedEvent event in rename function triggers it twice. You can try it out locally.
There was a problem hiding this comment.
does that mean it was actually a bug?
ioedeveloper
force-pushed
the
filemanager-api-e2e
branch
2 times, most recently
from
4041bef
to
1b2bac5
Compare
ioedeveloper
force-pushed
the
filemanager-api-e2e
branch
from
1b2bac5
to
0d3a63c
Compare
yann300
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/ethereum/remix-ide/issues/2911