Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE hover icons #4446

Merged
merged 15 commits into from
Feb 14, 2024
Merged

FE hover icons #4446

merged 15 commits into from
Feb 14, 2024

Conversation

joeizang
Copy link
Collaborator

Adds icons to file explorer when hovered over. Offers basic shortcut icons to create, rename and delete files or folders

@joeizang joeizang added the WIP label Jan 11, 2024
@joeizang joeizang self-assigned this Jan 11, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 11, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 7ae20c7
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/65cc888adaa69b000863679b
😎 Deploy Preview https://deploy-preview-4446--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang marked this pull request as draft January 11, 2024 12:56
@LianaHus LianaHus self-requested a review January 16, 2024 17:22
@joeizang joeizang force-pushed the fe-hoverIcons branch 2 times, most recently from 5d1d804 to 4cce5be Compare February 1, 2024 12:41
@joeizang joeizang marked this pull request as ready for review February 9, 2024 12:04
LianaHus
LianaHus previously requested changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@LianaHus LianaHus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

Some small notes from my side:

when I try to rename and then click on something else (abort it), I see the modal "A file or folder 1_Storage.sol already exists at this location. Please choose a different name." If the name staid the same it shouldn't be shown IMHO

LianaHus
LianaHus reviewed Feb 13, 2024
View reviewed changes
libs/remix-ui/workspace/src/lib/css/file-explorer.css Outdated
}

.remixui_icons_space {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you use bootstrap class here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. mr-2 does the trick

@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Feb 13, 2024
@yann300
Copy link
Contributor

yann300 commented Feb 14, 2024

when I try to rename and then click on something else (abort it), I see the modal "A file or folder 1_Storage.sol already exists at this location. Please choose a different name." If the name staid the same it shouldn't be shown IMHO

@LianaHus this is fixed now

@yann300 yann300 dismissed LianaHus’s stale review February 14, 2024 09:49

requested changes are applied

@yann300 yann300 merged commit 46459f2 into master Feb 14, 2024
32 checks passed
@yann300 yann300 deleted the fe-hoverIcons branch February 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann300 yann300 yann300 approved these changes

@LianaHus LianaHus Awaiting requested review from LianaHus

Assignees

@joeizang joeizang

Labels
ready-to-review PR ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joeizang @yann300 @LianaHus @bunsenstraat