add Learneth plugin #4466
add Learneth plugin #4466
Conversation
👷 Deploy request for remixproject accepted.
|
drafish
force-pushed
the
learneth
branch
2 times, most recently
from
e1fd9bb to
49d2d36
Compare
There was a problem hiding this comment.
we have it in assets folder.
There was a problem hiding this comment.
I tried to import the logo like this
import logo from '../../../../remix-ide/src/assets/img/remixLogo.webp'Then I got this error when I was building
I tried this way which works, check below
<img src="https://remix.ethereum.org/assets/img/remixLogo.webp" />But it's not elegant. Will that be ok? @LianaHus
There was a problem hiding this comment.
webp is also fine. depending on where you use it. does it work for both types of themes?
There was a problem hiding this comment.
I deleted the assets folder in learneth, get the assets from remix-ide folder. And yes, it works for both types of themes.
What you mean by BTW, I got the custom CSS classes from the old learneth plugin. @LianaHus |
| to={`/list?id=${item.id}`} | ||
| className="text-decoration-none float-right" | ||
| > | ||
| <FontAwesomeIcon icon={faPlayCircle} size="lg" /> |
There was a problem hiding this comment.
please use the same coding style as we do in other places.
example https://github.com/ethereum/remix-project/blob/master/libs/remix-ui/run-tab/src/lib/components/contractGUI.tsx#L366
There was a problem hiding this comment.
I resaved all files. Now it's using remix's coding style.
There was a problem hiding this comment.
I'm sorry I still see FontAwesomeIcon in the code.
There was a problem hiding this comment.
I'm sorry I still see FontAwesomeIcon in the code.
just removed. please check again. thanks @LianaHus
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
|
|
There was a problem hiding this comment.
please remove empty spaces
There was a problem hiding this comment.
removed here, and other files too.
|
Please, whatever is possible, do not use custom CSS classes but bootstrap once.
yes. we are removing custom classes everywhere and using bootstrap classes |
Can I do this in next PR? There are a lot custom css classes that need to be removed. That may take a while. @LianaHus |
drafish
force-pushed
the
learneth
branch
2 times, most recently
from
d0fb83e to
8d6b879
Compare
Remix LearnEth Plugin
Available Scripts
In the project directory, you can run:
npm run serve:plugin --plugin=learnethRuns the app in the development mode.
Open http://localhost:2024 to view it in the browser.
The page will reload if you make edits.
You will also see any lint errors in the console.
npm run build:plugin --plugin=learnethBuilds the app for production to the
dist/apps/learnethfolder.You can test it on chinese mirror site of remix ide -- https://remix.learnblockchain.cn/?#activate=LearnEth
Here is the url of learneth on mirror site -- https://remix.learnblockchain.cn/plugins/learneth/index.html