Save VM State and Blocks #4529
Merged
Save VM State and Blocks #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
reviewed
Feb 13, 2024
| @@ -889,8 +904,13 @@ export class Blockchain extends Plugin { | |||
| let execResult | |||
| let returnValue = null | |||
| if (isVM) { | |||
| const hhlogs = await this.web3().remix.getHHLogsForTx(txResult.transactionHash) | |||
| if (!tx.useCall) { | |||
There was a problem hiding this comment.
Saving the state should be done elsewhere, so it also takes in account txs done from a script.
ioedeveloper
force-pushed
the
vm-state
branch
from
3b18329
to
c169af8
Compare
yann300
reviewed
Feb 29, 2024
| @@ -36,5 +36,6 @@ | |||
| "settings.port": "PUERTO", | |||
| "settings.projectID": "ID DEL PROYECTO", | |||
| "settings.projectSecret": "SECRETO DE PROYECTO", | |||
| "settings.analyticsInRemix": "Analíticas en IDE Remix" | |||
| "settings.analyticsInRemix": "Analíticas en IDE Remix", | |||
| "settings.enableSaveEnvState": "Guardar el estado del entorno de implementación" | |||
There was a problem hiding this comment.
i think this is fine if you just put the english translation next time.
Translations are made from the crowd-in interface.
ioedeveloper
force-pushed
the
vm-state
branch
2 times, most recently
from
0c1c69b
to
68eb02e
Compare
yann300
reviewed
Mar 12, 2024
yann300
reviewed
Mar 12, 2024
yann300
reviewed
Mar 12, 2024
| @@ -90,3 +90,8 @@ export const saveIpfsSettingsToast = (config, dispatch, ipfsURL, ipfsProtocol, i | |||
| config.set('settings/ipfs-project-secret', ipfsProjectSecret) | |||
| dispatch({ type: 'save', payload: { message: 'IPFS settings have been saved' } }) | |||
| } | |||
|
|
|||
| export const saveEnvState = (config, checked, dispatch) => { | |||
| config.set('settings/save-evm-state', checked) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
I m thinking there should be a way to show from udapp that state is saved (next PR tho I guess) |
yann300
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.