Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vyper Plugin Patch/Ui Updates #4538

Merged
merged 31 commits into from
Feb 27, 2024
Merged

Vyper Plugin Patch/Ui Updates #4538

merged 31 commits into from
Feb 27, 2024

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Feb 15, 2024

fixes #4536 #4537

@joeizang joeizang added the WIP label Feb 15, 2024
@joeizang joeizang self-assigned this Feb 15, 2024
Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 53cfb74
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/65dd14ed339d0900083a59e1
😎 Deploy Preview https://deploy-preview-4538--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

<div className="pl-3 d-flex flex-row justify-content-between">
<CustomAccordionToggle eventKey="0">
<span className="">Advanced Compiler Settings</span>
</CustomAccordionToggle>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs the caret - like in the advanced settings in the Solidity compiler.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@joeizang joeizang force-pushed the vyperplugin-patch branch 2 times, most recently from 5151a64 to 1d0d0e4 Compare February 23, 2024 22:55
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make a little more graphic sense if when you click the local compiler, the text box appears just below the radio buttons and not below the the advice text about where to put the pragma stuff.

I"ll have the link for the compiler version today.

Will the snekmate repo be in this release - or the next one?

Is Ctrl +S working now? I think it isn't

and the evm version isnt being returned yet from Ape - right? Nor is the optimize - right?

@joeizang
Copy link
Collaborator Author

joeizang commented Feb 26, 2024

It would make a little more graphic sense if when you click the local compiler, the text box appears just below the radio buttons and not below the the advice text about where to put the pragma stuff.

I"ll have the link for the compiler version today.

Will the snekmate repo be in this release - or the next one?

Is Ctrl +S working now? I think it isn't

and the evm version isnt being returned yet from Ape - right? Nor is the optimize - right?

evm version isn't being returned by Apeworx yet.

Ctrl + S isn't working yet. That will come in the next release.

I will fix the placement of the warning message.

replacing snekmate will be tricky because all our vyper e2es are dependent on the examples folder in the current repo from vyperlang. If we can somehow have the example folder, it would make the transition easier.

Thanks @ryestew

Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For specifying the Vyper version, add this link
    https://remix-ide.readthedocs.io/en/latest/vyper.html#specify-vyper-version

  • The tab for compilation details doesn't say the contract's name - the title of the tab is contractName. This needs to be updated.

  • When you switch to another vyper file, the compilation details button should go away - just like it does in Solidity file.

  • I am not getting ctrl +s to work

  • When I click on a compiler error, the cursor should jump to the that line in the editor. That doesn't seem to be working now.

@Aniket-Engg Aniket-Engg merged commit 1e5f7ab into master Feb 27, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the vyperplugin-patch branch February 27, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vyper compiler error bugs
3 participants