-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vyper Plugin Patch/Ui Updates #4538
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eb7d438
to
fef4b72
Compare
ce93abb
to
66910fd
Compare
<div className="pl-3 d-flex flex-row justify-content-between"> | ||
<CustomAccordionToggle eventKey="0"> | ||
<span className="">Advanced Compiler Settings</span> | ||
</CustomAccordionToggle> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line needs the caret - like in the advanced settings in the Solidity compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
5151a64
to
1d0d0e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make a little more graphic sense if when you click the local compiler, the text box appears just below the radio buttons and not below the the advice text about where to put the pragma stuff.
I"ll have the link for the compiler version today.
Will the snekmate repo be in this release - or the next one?
Is Ctrl +S working now? I think it isn't
and the evm version isnt being returned yet from Ape - right? Nor is the optimize - right?
evm version isn't being returned by Apeworx yet. Ctrl + S isn't working yet. That will come in the next release. I will fix the placement of the warning message. replacing snekmate will be tricky because all our vyper e2es are dependent on the examples folder in the current repo from vyperlang. If we can somehow have the example folder, it would make the transition easier. Thanks @ryestew |
1d0d0e4
to
485b4e6
Compare
7f7bd8c
to
4489491
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
For specifying the Vyper version, add this link
https://remix-ide.readthedocs.io/en/latest/vyper.html#specify-vyper-version -
The tab for compilation details doesn't say the contract's name - the title of the tab is contractName. This needs to be updated.
-
When you switch to another vyper file, the compilation details button should go away - just like it does in Solidity file.
-
I am not getting ctrl +s to work
-
When I click on a compiler error, the cursor should jump to the that line in the editor. That doesn't seem to be working now.
fixes #4536 #4537