Preserve whitespace when loading a JSON file through a url querystring parameter
#4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for remixproject pending review.Visit the deploys page to approve it
|
yann300
approved these changes
Feb 19, 2024
|
@sangaline could you please rebase it? |
sangaline
force-pushed
the
ews-preserve-whitespace-when-opening-json-files
branch
from
bf894f2 to
4ef84e7
Compare
|
@yann300 I just rebased it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a JSON file using a
urlquerystring parameter, all whitespace is stripped from the file because the JSON is first parsed and then reserialized withJSON.stringify(content)if the content is not a Solidity compiler JSON-input-output file. If the purpose of the link is to open a human-readable JSON file in the editor, then removing the whitespace makes the file significantly less readable. This PR updates the logic to preserve the original formatting of the JSON file.An example of the current behavior is opening a Sindri Manifest file in the editor.