Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vyper UI Patch 003 #4585

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Vyper UI Patch 003 #4585

merged 5 commits into from
Mar 11, 2024

Conversation

joeizang
Copy link
Collaborator

fixes #4537 #4575

@joeizang joeizang added the WIP label Feb 28, 2024
@joeizang joeizang self-assigned this Feb 28, 2024
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 11c6043
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/65ef6446acf15a000816db57
😎 Deploy Preview https://deploy-preview-4585--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang force-pushed the vyperplugin-patch-003 branch from 4e01ada to 25aebdd Compare February 29, 2024 10:00
@joeizang joeizang requested a review from ryestew February 29, 2024 13:43
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels Feb 29, 2024
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old vyper logo is still showing in the FE:

image

is that because we need to redo the font-awesome icon for this - I mean I had updated it - and named it the same fa-vyper2. or soemthing like that - but maybe I need to make a new one called fa-vyper3. Is this the issue?

Everything else here in this PR seems fine.

@joeizang joeizang requested a review from ryestew March 9, 2024 00:03
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text input box for local compiler should be inside the accordion box for Advanced Features
So not like this:
image

@joeizang joeizang force-pushed the vyperplugin-patch-003 branch from d291d21 to df3f54c Compare March 11, 2024 19:26
@joeizang joeizang merged commit b6306f8 into master Mar 11, 2024
32 checks passed
@joeizang joeizang deleted the vyperplugin-patch-003 branch March 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vyper checklist
2 participants