Fix cli integration #4743
Merged
Fix cli integration #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yann300
force-pushed
the
fix_cli_integ
branch
2 times, most recently
from
6df1e2e
to
a2b6f87
Compare
yann300
force-pushed
the
fix_cli_integ
branch
8 times, most recently
from
f990754
to
2a5d1f0
Compare
yann300
force-pushed
the
fix_cli_integ
branch
3 times, most recently
from
c331317
to
a90a89d
Compare
Aniket-Engg
approved these changes
Jun 17, 2024
|
|
||
| browser.perform(async (done) => { | ||
| remixd = await spawnRemixd(join(process.cwd(), '/apps/remix-ide', '/contracts/hardhat')) | ||
| remixd = await spawnRemixd(join(process.cwd(), '/apps/remix-ide/hardhat-boilerplate')) |
There was a problem hiding this comment.
is /apps/remix-ide/hardhat-boilerplate path existing?
| async function setupHardhatProject(): Promise<void> { | ||
| console.log(process.cwd()) | ||
| try { | ||
| const server = spawn('git clone https://github.com/NomicFoundation/hardhat-boilerplate && cd hardhat-boilerplate && yarn install && yarn add "@typechain/ethers-v5@^10.1.0" && yarn add "@typechain/hardhat@^6.1.2" && yarn add "typechain@^8.1.0" && echo "END"', [], { cwd: process.cwd() + '/apps/remix-ide', shell: true, detached: true }) |
There was a problem hiding this comment.
ok, I see. It is here
| @@ -374,6 +374,7 @@ export function ContractDropdownUI(props: ContractDropdownProps) { | |||
| evmVersion = JSON.parse(loadedContractData.metadata).settings.evmVersion | |||
| } | |||
| } catch (err) {} | |||
| console.log('current file', currentFile) | |||
Aniket-Engg
force-pushed
the
fix_cli_integ
branch
2 times, most recently
from
51d50da
to
ae878da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Foundry integration and improve e2e tests.