Pinned panel #4798
Merged
Pinned panel #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioedeveloper
requested review from
bunsenstraat,
joeizang,
ryestew,
yann300,
LianaHus and
Aniket-Engg
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ioedeveloper
force-pushed
the
pinned-panel
branch
from
263df60
to
88d8db4
Compare
Aniket-Engg
reviewed
May 15, 2024
| @@ -4,6 +4,8 @@ | |||
| "panel.documentation": "Documentation", | |||
| "panel.description": "Description", | |||
| "panel.maintainedByRemix": "Maintained by Remix", | |||
| "panel.pinnedMsg": "Click to dock plugin to the right", | |||
| "panel.unPinnedMsg": "Click to return plugin to the side panel", | |||
There was a problem hiding this comment.
may be better to say: Click to return plugin to the left side panel
There was a problem hiding this comment.
Agree. Maybe even same sentence but with right/left
ryestew
requested changes
May 15, 2024
There was a problem hiding this comment.
- When you pin a panel - it pops to the right - but the main panel and the terminal get a ugly scroll bar that is not aligned with each other.
- Learneth should appear on the right side by default. A new user won't know how to pin it.
- I am not sure pinning is the right word...lets discuss...
- Also left side panels have the old style of scroll bar - like mentioned above:
- maybe the pin should be an arrow icon:
LianaHus
requested changes
May 16, 2024
| @@ -6,5 +6,7 @@ | |||
| "panel.maintainedByRemix": "由 Remix 维护", | |||
| "panel.pluginInfo": "插件信息", | |||
| "panel.linkToDoc": "文档链接", | |||
| "panel.makeAnissue": "提交 issue" | |||
| "panel.makeAnissue": "提交 issue", | |||
There was a problem hiding this comment.
You don't need to add those in all language files. It will take English by default anyway. Just add the label "needs translation".
| @@ -34,6 +34,12 @@ pre { | |||
| width : 320px; | |||
| transition : width 0.25s; | |||
| } | |||
| .pinnedpanel { | |||
| display : flex; | |||
| flex-direction : row-reverse; | |||
There was a problem hiding this comment.
Please use bootstrap classes for first two
|
@ioedeveloper please exclude the plugins you've added from the plugin manager |
ioedeveloper
force-pushed
the
pinned-panel
branch
from
7212c06
to
567f277
Compare
joeizang
approved these changes
May 21, 2024
ioedeveloper
force-pushed
the
pinned-panel
branch
from
567f277
to
33f0007
Compare
ryestew
approved these changes
May 30, 2024
LianaHus
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3787
How it works
This PR introduces the functionality of being able to pin/dock a plugin to a fixed position on the right of the IDE.
NOTE: We would need to discuss the plugins that should have this new icon to pin and unpin plugins.
NOTE: For now, only internal plugins have the ability to maintain state when pinned from left to right and vice-versa. Iframe plugins will have to reload when it switches sides. Also, i have only implemented state persistence for udapp and search plugin, because they are the easiest to implement for now because of how state is managed in this two plugins. Implementing for other internal plugins will involve a lot of code changes, which is out of the scope of this PR.