Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed scam alerts in Desktop IDE (issue #4740) #5085

Merged

Conversation

ijlal321
Copy link
Contributor

@ijlal321 ijlal321 commented Aug 17, 2024

removed scam alert notification and (orange box) and from status bar for remix Desktop.

image

here is original issue
#4740
let me know if need any inquiries, thanks

Copy link

netlify bot commented Aug 17, 2024

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 38af730

@bunsenstraat
Copy link
Collaborator

bunsenstraat commented Aug 22, 2024

You need to use the context to detect app state in tsx, you can see an example in : libs/remix-ui/home-tab/src/lib/remix-ui-home-tab.tsx

import { appPlatformTypes, platformContext } from '@remix-ui/app'
 const platform = useContext(platformContext)
{!(platform === appPlatformTypes.desktop) ? ....

@ijlal321
Copy link
Contributor Author

@bunsenstraat thanks for your input. I have updated the code. Let me know if you need anything else 👍

@bunsenstraat bunsenstraat force-pushed the Remix-Desktop-Scam-Alert-Bug-Fix branch from 9ef71bd to 38af730 Compare September 2, 2024 07:01
@Aniket-Engg Aniket-Engg merged commit 874b405 into ethereum:master Sep 2, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants