Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

minor fixes #1085

Closed
wants to merge 1 commit into from
Closed

minor fixes #1085

wants to merge 1 commit into from

Conversation

evgeniuz
Copy link

  • removed bin configuration from package.json: this package doesn't provide binary file, so it causes errors on installation;
  • fixed parameter passed to combineSource recurrent call: it's called fileRoot, not rootpath now.

@yann300
Copy link
Collaborator

yann300 commented Mar 25, 2019

@0mkara what should we do with this PR? Is this still valid?

@0mkara
Copy link
Collaborator

0mkara commented Mar 25, 2019

No. This PR becomes invalid as we are not using combineSource() anymore. Here is the new resolve() mechanism.

https://github.com/ethereum/remix/blob/master/remix-url-resolver/src/resolve.ts#L114

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants