This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Fix library bytecode comparison #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
May 9, 2018
remix-lib/src/util.js
Outdated
| @@ -187,6 +187,11 @@ module.exports = { | |||
| if (code1 === code2) return true | |||
| if (code2 === '0x') return false // abstract contract. see comment | |||
|
|
|||
| if (code2.substr(4, 40) === '0000000000000000000000000000000000000000') { | |||
There was a problem hiding this comment.
It should also check for the push opcode to be safe.
Perhaps even check for the entire signature from here https://github.com/ethereum/solidity/blob/develop/libsolidity/codegen/ContractCompiler.cpp#L277 :
PUSH20 00..00 ADDRESS EQ
axic
reviewed
May 9, 2018
remix-lib/src/util.js
Outdated
| if (code2.substr(4, 40) === '0000000000000000000000000000000000000000') { | ||
| // in the context of a library, that slot contains the address of the library (pushed by the compiler to avoid calling library other than with a DELEGATECALL) | ||
| // if code2 is not a library, well we still suppose that the comparison remain relevant even if we remove some information from `code1` | ||
| code1 = replaceLibReference(code1, 4) |
There was a problem hiding this comment.
I think this will replace 32 bytes?
There was a problem hiding this comment.
should not, should be 20 bytes
There was a problem hiding this comment.
replaceLibReference seems to have a lot of zero padding
There was a problem hiding this comment.
replaceLibReference inject a null address, so I think that is ok here..
yann300
force-pushed
the
fixLibraryComparison
branch
from
0cbfb3b
to
b358155
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of a library, deployed bytecode contains the address of the library (pushed by the compiler to avoid calling library other than with a DELEGATECALL)
If code2 is not a library, we still suppose that the comparison remains relevant even if we remove some information from
code1