Add EOF Errors to evmone configuration #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
force-pushed
the
develop
branch
2 times, most recently
from
43ed042
to
c07f2a5
Compare
gumb0
reviewed
Mar 5, 2024
Comment on lines
332
to
341
| echo $result | grep "OK" > /dev/null | ||
| if [ $? -eq 0 ]; then | ||
| echo "ok." | ||
| else | ||
| echo "$result" | ||
| fi |
There was a problem hiding this comment.
But we'd be fine with merging it with this workaround for now.
There was a problem hiding this comment.
The response can verify in eof validation code yes
gumb0
approved these changes
Mar 13, 2024
winsvega
reviewed
Mar 20, 2024
| if [ $1 = "eof" ] || [ $1 = "t8n" ] || [ $1 = "b11r" ]; then | ||
| evmone $1 $2 $3 $4 $5 $6 $7 $8 $9 $10 $11 $12 $13 $14 $15 $16 $17 $18 $19 $20 $21 $22 $23 $24 $25 $26 | ||
| if [ $1 = "t8n" ] || [ $1 = "b11r" ]; then | ||
| evmone-t8n $2 $3 $4 $5 $6 $7 $8 $9 $10 $11 $12 $13 $14 $15 $16 $17 $18 $19 $20 $21 $22 $23 $24 $25 $26 |
There was a problem hiding this comment.
Need to check if it still works with .py tests.
winsvega
reviewed
Mar 20, 2024
| evmone -v | ||
| evmone-t8n -v | ||
| elif [ $1 = "eof" ]; then | ||
| result=$(echo $5 | evmone-eofparse) |
There was a problem hiding this comment.
Passing number 5 here is bot reliable. Its position might change. What are the 2, 3, 4 that ignored?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.