-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nethermind evm to docker file #229
base: develop
Are you sure you want to change the base?
Changes from all commits
f61d56b
d959572
bbc435d
0fbc64b
77aff64
1779e9a
87a681e
3b8de4e
8815faa
840117b
0068f0d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -112,6 +112,9 @@ if [ "$SCRIPT_NAME" = "dtf.sh" ]; then | |
if [ "$var" = "nimbus" ]; then | ||
binpath="/bin/evm_nimbus" | ||
fi | ||
if [ "$var" = "nethermind" ]; then | ||
binpath="/nethermind/tools/Evm/Evm/bin/Debug/net8.0/Evm" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. to save space I copy built binaries into bin folder inside docker and remove all src and build files that are no longer required for it to run. making docker image smaller. |
||
fi | ||
if [ "$var" = "besu" ]; then | ||
binpath="/usr/bin/besuevm" | ||
fi | ||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,16 +21,14 @@ void requireStateTestsFillerEnvScheme(spDataObject const& _data) | |
{"currentRandom", {{DataType::String}, jsonField::Optional}}, | ||
{c_parentExcessBlobGas, {{DataType::String}, jsonField::Optional}}, | ||
{c_parentBlobGasUsed, {{DataType::String}, jsonField::Optional}}, | ||
{c_currentBeaconRoot, {{DataType::String}, jsonField::Optional}}, | ||
{"previousHash", {{DataType::String}, jsonField::Required}}}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this seems to be a rebase issue. can you rebase on top of develop branch? |
||
{c_currentBeaconRoot, {{DataType::String}, jsonField::Optional}}}); | ||
} | ||
|
||
void convertEnvDecFieldsToHex(spDataObject& _data) | ||
{ | ||
(*_data).performModifier(mod_valueToCompactEvenHexPrefixed, DataObject::ModifierOption::RECURSIVE, | ||
{"currentCoinbase", "previousHash", "currentRandom"}); | ||
{"currentCoinbase", "currentRandom"}); | ||
(*_data).atKeyUnsafe("currentCoinbase").performModifier(mod_valueInsertZeroXPrefix); | ||
(*_data).atKeyUnsafe("previousHash").performModifier(mod_valueInsertZeroXPrefix); | ||
(*_data).performModifier(mod_valueToLowerCase); | ||
} | ||
} // namespace | ||
|
@@ -64,8 +62,6 @@ void StateTestFillerEnv::initializeFields(spDataObject const& _data) | |
// Indicates zero block timestamp in StateTests | ||
m_genesisTimestamp = sVALUE(0); | ||
|
||
m_previousHash = sFH32(_data->atKey("previousHash")); | ||
|
||
spDataObject tmpD(new DataObject("0x00")); // State Tests extra data is 0x00 | ||
m_currentExtraData = sBYTES(tmpD); | ||
m_currentNonce = spFH8(FH8::zero().copy()); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to move this under condition as well. as if docker is being built for geth only no need to install nethermind pre requirements