Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cimg/node instead of deprecated circleci/node #747

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

r0qs
Copy link
Member

@r0qs r0qs commented Sep 4, 2024

During the 0.8.27 release I noticed that we missed to upgrade the image used by solidity-solcjs-ext-test in our CI config.

This PR upgrades such CircleCI convenience image to fix the following warning: https://app.circleci.com/pipelines/github/ethereum/solc-js/1670/workflows/34f69e77-0e63-491e-8d41-d0c62663c700/jobs/10461

More info about the deprecation here: https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034

@r0qs r0qs requested a review from nikola-matic September 4, 2024 12:38
@coveralls
Copy link

Coverage Status

coverage: 84.537%. remained the same
when pulling 71a6cf5 on upgrade-docker-convenience-image
into e7eeaf9 on master.

@r0qs r0qs enabled auto-merge September 4, 2024 12:40
@r0qs r0qs requested a review from clonker September 4, 2024 12:41
@r0qs r0qs merged commit d75cc7f into master Sep 4, 2024
17 checks passed
@r0qs r0qs deleted the upgrade-docker-convenience-image branch September 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants