fixup! Add semantic tests for duplicated function definitions with sa…

…me function id in internal dispatcher
ethereum · Sep 26, 2023 · ca75a35 · ca75a35
1 parent 6deb2a3
commit ca75a35
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/libsolidity/codegen/ir/IRGenerationContext.cpp b/libsolidity/codegen/ir/IRGenerationContext.cpp
@@ -150,13 +150,13 @@ InternalDispatchMap IRGenerationContext::consumeInternalDispatchMap()
 void IRGenerationContext::addToInternalDispatch(FunctionDefinition const& _function)
 {
 	FunctionType const* functionType = TypeProvider::function(_function, FunctionType::Kind::Internal);
-	solAssert(functionType, "");
+	solAssert(functionType);
 
 	YulArity arity = YulArity::fromType(*functionType);
-	auto it = ranges::find(m_internalDispatchMap[arity], &_function);
-	if (it == ranges::end(m_internalDispatchMap[arity]))
+	DispatchQueue& dispatchQueue = m_internalDispatchMap[arity];
+	if (ranges::find(dispatchQueue, &_function) == ranges::end(dispatchQueue))
 	{
-		m_internalDispatchMap[arity].push_back(&_function);
+		dispatchQueue.push_back(&_function);
 		enqueueFunctionForCodeGeneration(_function);
 	}
 }