Non-fatal erros do not stop ASTJSON test execution

ethereum · Feb 21, 2022 · ff44c8a · ff44c8a
1 parent c44fd13
commit ff44c8a
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/test/libsolidity/ASTJSONTest.cpp b/test/libsolidity/ASTJSONTest.cpp
@@ -141,13 +141,13 @@ TestCase::TestResult ASTJSONTest::run(ostream& _stream, string const& _linePrefi
 
 		if (!c.parseAndAnalyze(variant.stopAfter))
 		{
-			// Ignore non-fatal analysis errors, we only want to export.
-			if (c.state() > CompilerStack::State::Parsed)
-				continue;
-
-			SourceReferenceFormatter formatter(_stream, c, _formatted, false);
-			formatter.printErrorInformation(c.errors());
-			return TestResult::FatalError;
+			// We just want to export so raise fatal analysis errors only
+			if (c.state() < CompilerStack::State::ParsedAndImported)
+			{
+				SourceReferenceFormatter formatter(_stream, c, _formatted, false);
+				formatter.printErrorInformation(c.errors());
+				return TestResult::FatalError;
+			}
 		}
 
 		resultsMatch = resultsMatch && runTest(