Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test cases from SolidityEndToEnd to semanticTests #12253

Closed
axic opened this issue Nov 8, 2021 · 2 comments
Closed

Move test cases from SolidityEndToEnd to semanticTests #12253

axic opened this issue Nov 8, 2021 · 2 comments
Labels
closed due inactivity The issue/PR was automatically closed due to inactivity. good first issue hacktoberfest-accepted stale The issue/PR was marked as stale because it has been open for too long. testing 🔨

Comments

@axic
Copy link
Member

axic commented Nov 8, 2021

There is the test/libsolidity/SolidityEndToEndTest.cpp file, which contains a lot of semantic tests. It is a large monolithic single C++ file, which takes a long time to compile and is hard to maintain.

We want to move as many test cases out to individual files under test/libsolidity/semanticTests. They should be grouped logically, by following the grouping in SolidityEndToEnd.

Have a look at existing test case in both places to see how they operate.

(This was previously designed/discussed in #3486, but creating a new issue to be more helpful.)
@axic axic mentioned this issue Nov 8, 2021
Closed
This was referenced Nov 16, 2021
Merged
Merged
@cameel cameel mentioned this issue Dec 21, 2021
Closed
@NunoFilipeSantos NunoFilipeSantos added the good first issue candidate Could be a "good first issue" but something is blocking it or it has open questions. label Dec 5, 2022
@cameel cameel added good first issue and removed good first issue good first issue candidate Could be a "good first issue" but something is blocking it or it has open questions. labels Dec 5, 2022
@cameel cameel mentioned this issue Jan 27, 2023
Closed
@github-actions
Copy link

This issue has been marked as stale due to inactivity for the last 90 days.
It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Mar 21, 2023
@github-actions
Copy link

Hi everyone! This issue has been automatically closed due to inactivity.
If you think this issue is still relevant in the latest Solidity version and you have something to contribute, feel free to reopen.
However, unless the issue is a concrete proposal that can be implemented, we recommend starting a language discussion on the forum instead.

@github-actions github-actions bot added the closed due inactivity The issue/PR was automatically closed due to inactivity. label Mar 30, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed due inactivity The issue/PR was automatically closed due to inactivity. good first issue hacktoberfest-accepted stale The issue/PR was marked as stale because it has been open for too long. testing 🔨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@axic @cameel @NunoFilipeSantos @nikola-matic