Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused endToEndExtraction scripts #13852

Closed
r0qs opened this issue Jan 6, 2023 · 5 comments · Fixed by #13888
Closed

Remove unused endToEndExtraction scripts #13852

r0qs opened this issue Jan 6, 2023 · 5 comments · Fixed by #13888
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. refactor

Comments

@r0qs
Copy link
Member

r0qs commented Jan 6, 2023 •
edited
Loading

Remove obsolete endToEndExtraction scripts.
@r0qs r0qs mentioned this issue Jan 6, 2023
Closed
@n1charlie n1charlie mentioned this issue Jan 25, 2023
Merged
@aarlt
Copy link
Member

aarlt commented Jan 26, 2023

Maybe we could just remove the whole scripts/endToEndExtraction directory. I guess the probability is quite low that we will need that again. However, why should we only remove that verify-testcases.py script?

@r0qs
Copy link
Member Author

r0qs commented Jan 27, 2023 •
edited
Loading

Indeed. We should remove all endToEndExtraction if they are no longer used. I updated the title and issue description.

@r0qs r0qs changed the title Remove unused endToEndExtraction script Remove unused endToEndExtraction scripts Jan 27, 2023
@cameel
Copy link
Member

cameel commented Jan 27, 2023

I see that we did test extraction in #8464 and #8518. In #8197 (comment) @chriseth said that most of the remaining tests check for events. We also still have #12253 open (SolidityEndToEndTest.cpp still has ~4k lines) and isoltest now supports events (#11050). So are we sure we won't be doing any more extraction?

@cameel cameel added low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. refactor labels Jan 27, 2023
@r0qs
Copy link
Member Author

r0qs commented Feb 5, 2023

Right. We could quickly discuss that in the meeting this week then.

@ekpyron
Copy link
Member

ekpyron commented Feb 7, 2023

Nobody said we wouldn't extract anything else, but I don't see us using the scripts for whatever remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove obsolete endToEndExtraction script n1charlie/solidity
4 participants
@cameel @r0qs @ekpyron @aarlt