[test] Extract 45 more tests from SolidityEndToEndTest.cpp #8518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chriseth I'm not sure what are the reasons for these errors. I'm not able to reproduce them. Can you take a look? |
chriseth
reviewed
Mar 25, 2020
test/libsolidity/semanticTests/extracted/delegatecall_return_value.sol
Outdated
Show resolved
Hide resolved
chriseth
reviewed
Mar 25, 2020
test/libsolidity/semanticTests/extracted/staticcall_for_view_and_pure.sol
Outdated
Show resolved
Hide resolved
aarlt
force-pushed
the
extract-more-testcases
branch
3 times, most recently
from
0fd3043 to
73615c4
Compare
chriseth
reviewed
Mar 26, 2020
chriseth
reviewed
Mar 26, 2020
| // ==== | ||
| // EVMVersion: <byzantium | ||
| // ---- | ||
| // f() -> 0x1 # This should work, next should throw # |
chriseth
force-pushed
the
extract-more-testcases
branch
from
f877d53 to
165f7bf
Compare
chriseth
approved these changes
Mar 26, 2020
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.