Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete endToEndExtraction script #13888

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

tqpcharlie
Copy link
Contributor

Closes #13852

@github-actions
Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@r0qs
Copy link
Member

r0qs commented Jan 27, 2023

Hi @Zachinquarantine, thanks for your contribution. Could you also remove the whole endToEndExtraction folder? It turns out that we don't need it anymore. See here for reference: #13852 (comment)

@cameel cameel added the takeover Can be taken over by someone other than label giver label Feb 10, 2023
@cameel cameel marked this pull request as draft February 10, 2023 20:38
@matheusaaguiar
Copy link
Collaborator

Took over and removed the folder. Also rebased on develop.

@matheusaaguiar matheusaaguiar self-assigned this Feb 17, 2023
@r0qs r0qs marked this pull request as ready for review February 18, 2023 10:42
@cameel cameel merged commit 13c0d93 into ethereum:develop Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contribution ⭐ takeover Can be taken over by someone other than label giver testing 🔨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused endToEndExtraction scripts
4 participants